Open
Conversation
chrisk
added a commit
that referenced
this pull request
Jun 13, 2017
Thanks for reporting: @strzibny in #48, @ggilder in #50, @davidcornu in #58, and @SamMolokanov in #60. References #57.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is a first attempt to use Minitest 5 for the fakeweb's test suite. I needed to do this patch to fix the build for Fedora rawhide which uses new Rails (4.1) and therefore new Minitest (5). Also, Ruby upstream already dropped
test/unitfrom Ruby core so I believe it's a right time to consider using Minitest 5. I understand that you prefer to be compatible with older Rubies and Rubinius and I didn't check for the possible issues yet, but I am filing this to keep track and discuss the change. Thanks.